[draft] Refactor some validation.cpp methods to return BlockValidationState#7
Draft
optout21 wants to merge 5 commits into
Draft
[draft] Refactor some validation.cpp methods to return BlockValidationState#7optout21 wants to merge 5 commits into
optout21 wants to merge 5 commits into
Conversation
optout21
force-pushed
the
2605-validation-state-return
branch
2 times, most recently
from
d78b817 to
44d3197
Compare
optout21
force-pushed
the
2605-validation-state-return
branch
5 times, most recently
from
a52e467 to
fd9b639
Compare
Owner
Author
|
Note: bitcoin#33856 has been merged |
optout21
force-pushed
the
2605-validation-state-return
branch
from
fd9b639 to
aa67944
Compare
Return BlockValidationState by value instead of using an out-parameter, similar to the TestBlockValidity refactoring in 74690f4. Remove redundant int return from btck_chainstate_manager_process_block_header. Previously returned both an int result and an output validation state parameter, creating ambiguity where non-zero could mean either invalid header or processing failure. Since ProcessNewBlockHeaders already provides complete validation info, the int return was redundant. Co-authored-by: stringintech <stringintech@gmail.com> Co-authored-by: stickies-v <stickies-v@protonmail.com>
optout21
force-pushed
the
2605-validation-state-return
branch
from
aa67944 to
771a265
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of # 33856