[ENH] Implement server-side services for most important functionalities

[mdmontesinos]

Oqtane Info

Version - 6.1.1
Render Mode - Static
Interactivity - Server
Database - SQL Server

Describe the enhancement

Similar to how the HtmlText module operates, all services should have client and server implementations to avoid API requests when using either Static or Interactive Server modes.

This means extracting the functionality from the controllers into a server-side service, which would be directly accessed instead of making an API request.

I understand this is quite a huge refactoring, so perhaps it should be done first in the most used (or consuming) services. For example, Settings, UrlMapping, ModuleDefinition, Site, Page, PageModule, User, File, Folder, ...

Anything else?

[sbwalker]

You are correct that this is a huge refactoring... and is difficult to quantify in terms of benefit. In most scenarios, the state which module developers need is exposed through the PageState or ModuleState objects - which means they do not need to call the core services at all. As a result I am classifying this item as much lower priority than other framework enhancements.

[mdmontesinos]

I'm not actually worried about developers calling the core services (as you mentioned, it's not the typical case). I'm referring to the calls the framework does everytime you navigate to a page to retrieve the page, module definitions, checking if there are url mappings, fetching the current user, ... Another example could be the file manager, that makes quite a few calls to fetch the folders and files.

For example, this api call made during the initial loading of a page could be replaced with server side services:

Request starting HTTP/1.1 GET https://localhost:44357/api/Setting?entityname=Module&entityid=132 - - -

[sbwalker]

I am not sure I understand what you are referring to. The app.razor runs server-side and handles each request. All of the methods within app.razor use Repository methods - they do not use the Service API. The API call you referred to above is related to GetModuleSettingsAsync() and if I put a breakpoint on that method, it is not called as I navigate the pages in a default installation. Is it possible that your custom modules are calling GetModuleSettingsAsync() instead of using the ModuleState.Settings() property?

[mdmontesinos]

You're totally right, it was a custom module using the incorrect call to settings.