Skip to content

Adding NPD changes and health check #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2025
Merged

Adding NPD changes and health check #57

merged 2 commits into from
Nov 22, 2025
+683 −421

Conversation

@rtkgupta
Copy link
Contributor

@rtkgupta rtkgupta commented Nov 21, 2025 •
edited
Loading

Updating NPD to latest dr hpc codes, and updating health check to use latest images

@rtkgupta
Adding NPD changes and health check
f4a0e19 
Signed-off-by: Ritika Gupta <rtkgupta203@gmail.com>
@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Nov 21, 2025

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 21, 2025
amgowda-oci
amgowda-oci reviewed Nov 21, 2025
View reviewed changes
oci-scanner-plugin-helm/templates/node-problem-detector.yaml Outdated
"enable_message_change_based_condition_update": true
},
"source": "dr-hpc",
"conditions": [
Copy link
Member

@amgowda-oci amgowda-oci Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant these conditions be moved into a dedicated.json file so is outside of the container and easy to update?

Copy link
Contributor Author

@rtkgupta rtkgupta Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@rtkgupta
Abstract condidtions to a json file, update active health container
f5e2386 
Signed-off-by: Ritika Gupta <rtkgupta203@gmail.com>
@rtkgupta rtkgupta mentioned this pull request Nov 22, 2025
Merged
@rtkgupta rtkgupta merged commit 2d404d8 into main Nov 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amgowda-oci amgowda-oci amgowda-oci left review comments

@gablyu-oci gablyu-oci Awaiting requested review from gablyu-oci

Assignees

No one assigned

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rtkgupta @amgowda-oci