Skip to content

Bugfix: AMD metrics push to prometheus #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gablyu-oci merged 6 commits into from
Dec 5, 2025
Merged

Bugfix: AMD metrics push to prometheus #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c92969
add post-upgrade hook to enable hostNetwork for AMD GPU exporter Daemon
gablyu-oci Dec 2, 2025
37b8078
Update default values
gablyu-oci Dec 2, 2025
6232861
Updated AMD metrics names
gablyu-oci Dec 2, 2025
3349ed1
Updated parallelism and completions in health check
gablyu-oci Dec 3, 2025
6588f4c
Removed amd exporter patch job
gablyu-oci Dec 3, 2025
b511f46
Update AMD hostname expressions
gablyu-oci Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions grafana_dashboards/oke-workloads-to-gpuscanner-mapping-dashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2567,7 +2567,7 @@
"uid": "{{DATASOURCE_PROMETHEUS}}"
},
"editorMode": "code",
"expr": "DCGM_FI_DEV_GPU_TEMP{Hostname=~\"$hostname\"} OR gpu_junction_temperature{hostname=~\"$hostname\"}",
"expr": "DCGM_FI_DEV_GPU_TEMP{Hostname=~\"$hostname\"} OR (amd_gpu_junction_temperature * on(node) group_left(hostname) (max by(node, hostname) (oci_lens_pod_node_info{hostname=~\"$hostname\"})))",
"hide": false,
"instant": false,
"interval": "",
Expand Down Expand Up @@ -2642,7 +2642,7 @@
"uid": "{{DATASOURCE_PROMETHEUS}}"
},
"editorMode": "code",
"expr": "avg(DCGM_FI_DEV_POWER_USAGE{Hostname=~\"$hostname\"} OR gpu_power_usage{hostname=~\"$hostname\"})",
"expr": "avg(DCGM_FI_DEV_POWER_USAGE{Hostname=~\"$hostname\"} OR (amd_gpu_power_usage * on(node) group_left(hostname) (max by(node, hostname) (oci_lens_pod_node_info{hostname=~\"$hostname\"}))))",
"hide": false,
"instant": false,
"legendFormat": "__auto",
Expand Down Expand Up @@ -2717,7 +2717,7 @@
"uid": "{{DATASOURCE_PROMETHEUS}}"
},
"editorMode": "code",
"expr": "avg(DCGM_FI_DEV_GPU_TEMP{Hostname=~\"$hostname\"} OR gpu_junction_temperature{hostname=~\"$hostname\"}) ",
"expr": "avg(DCGM_FI_DEV_GPU_TEMP{Hostname=~\"$hostname\"} OR (amd_gpu_junction_temperature * on(node) group_left(hostname) (max by(node, hostname) (oci_lens_pod_node_info{hostname=~\"$hostname\"})))) ",
"interval": "",
"legendFormat": "Avg GPU Temperature",
"range": true,
Expand Down Expand Up @@ -2824,7 +2824,7 @@
"uid": "{{DATASOURCE_PROMETHEUS}}"
},
"editorMode": "code",
"expr": "avg(DCGM_FI_DEV_GPU_UTIL{Hostname=~\"$hostname\"} OR gpu_gfx_activity{hostname=~\"$hostname\"})",
"expr": "avg(DCGM_FI_DEV_GPU_UTIL{Hostname=~\"$hostname\"} OR (amd_gpu_gfx_activity * on(node) group_left(hostname) (max by(node, hostname) (oci_lens_pod_node_info{hostname=~\"$hostname\"}))))",
"interval": "",
"legendFormat": "{{Hostname}}{{hostname}}",
"range": true,
Expand Down Expand Up @@ -2929,7 +2929,7 @@
"uid": "{{DATASOURCE_PROMETHEUS}}"
},
"editorMode": "code",
"expr": "DCGM_FI_DEV_POWER_USAGE{Hostname=~\"$hostname\"} OR gpu_power_usage{hostname=~\"$hostname\"}",
"expr": "DCGM_FI_DEV_POWER_USAGE{Hostname=~\"$hostname\"} OR (amd_gpu_power_usage * on(node) group_left(hostname) (max by(node, hostname) (oci_lens_pod_node_info{hostname=~\"$hostname\"})))",
"interval": "",
"legendFormat": "GPU {{gpu}}{{gpu_id}} - {{Hostname}}{{hostname}}",
"range": true,
Expand Down
4 changes: 2 additions & 2 deletions oci-scanner-plugin-helm/templates/health-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ metadata:
component: gpu-monitoring
priority: low
spec:
parallelism: 1
completions: 1
parallelism: 3
completions: 3
activeDeadlineSeconds: 7200
backoffLimit: 0
ttlSecondsAfterFinished: {{ .Values.healthCheck.ttlSecondsAfterFinished | default 86400 }} # Clean up after 24h
Expand Down
1 change: 0 additions & 1 deletion oci-scanner-plugin-helm/templates/node-problem-detector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ spec:
- args:
- /node-problem-detector --logtostderr --prometheus-port=${PROMETHEUS_PORT}
--prometheus-address 0.0.0.0 --config.system-log-monitor=/config/kernel-monitor.json,/config/readonly-monitor.json
--config.custom-plugin-monitor=/node-problem-detector-custom-check/imds_reachability.json
{{- if .Values.nodeProblemDetector.enableGpuChecks }}
--config.custom-plugin-monitor=/node-problem-detector-gpu-check/dr-hpc.json
{{- end }}
Expand Down
7 changes: 4 additions & 3 deletions oci-scanner-plugin-helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ device-metrics-exporter-charts:
global:
imageRegistry: ""
platform: k8s
hostNetwork: true
nodeSelector:
amd.com/gpu: "true"
kubelet:
Expand Down Expand Up @@ -107,7 +108,7 @@ metricsPushJob:

# Active Health Check
healthCheck:
enabled: false
enabled: true
image:
repository: oci_lens_healthcheck_amd
tag: v0.0.5
Expand Down Expand Up @@ -166,7 +167,7 @@ rbac:

# Node Exporter
nodeExporter:
enabled: false
enabled: true

# Override default values for the official chart
prometheus-node-exporter:
Expand Down Expand Up @@ -216,7 +217,7 @@ podNodeMapper:

# Node Problem Detector
nodeProblemDetector:
enabled: false
enabled: true
enableGpuChecks: true # Enable GPU health checks via DRHPC

# DRHPC results path - must match the hostPath where DRHPC writes results
Expand Down