Skip to content

Conversation

@Mahuwa-Barman
Copy link
Contributor

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • PR author: Mahuwa-Barman

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 9, 2024
@Mahuwa-Barman Mahuwa-Barman requested a review from telake May 9, 2024 12:45
Copy link
Member

@telake telake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Placement of changes look consistent with network_compartment_id where we default to compartment_ocid in locals.

@Mahuwa-Barman Mahuwa-Barman removed the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 9, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 9, 2024
@Mahuwa-Barman Mahuwa-Barman merged commit d06415f into topic-secure-production-mode May 10, 2024
@Mahuwa-Barman Mahuwa-Barman deleted the topic_mb-JCS-14447_JCS-14448 branch May 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants