COH-24004 - The Operator runner should support the JIB JVM argument files #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegridman
reviewed
Sep 23, 2021
pkg/runner/runner.go
Outdated
| func createJavaCommand(javaCmd string, details *RunDetails) (*exec.Cmd, error) { | ||
| args := details.getCommand() | ||
| appDir := details.getenvOrDefault(v1.EnvVarCohAppDir, "/app") | ||
| jibMainClassFileName := appDir + "/jib-main-class-file" |
Member
There was a problem hiding this comment.
I think this is in the wrong place. We determine the main class to use in the func server(details *RunDetails, _ *cobra.Command) line 43 of cmd_server.go. We get the value of the environment variable v1.EnvVarAppMainClass which will be set if the user specified a main class in their yaml. If this is not set, i.e. found == false then do your stuff before the switch. If you find a JIB main class in the file set mc to be the class name and set found = true.
Contributor
Author
There was a problem hiding this comment.
That makes a lot of sense. Thanks JK. I'll make that change
thegridman
approved these changes
Sep 24, 2021
thegridman
pushed a commit
to thegridman/coherence-operator
that referenced
this pull request
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.