[GR-65035] Implement JSObject field accesses using JSStubMethods #11244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every access generates a method call to a dynamically generated method that is (implicitly) annotated with @js(...) to perform the access on the JS side. This replaces the more clunky ForeignCall-based implementation that emitted all the necessary conversion/coercion code in-line at every access.
It is not allowed by the API docs and now also forbidden in practice
This was the original intent. This way, not state is split between the JS and Java mirror. It is also the less confusing behavior, allowing private, fields, but not exposing them to JS, could be unexpected
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly changes the interop API:
finalfields are no longer allowed and will produce aUserErrorwhen an access is seen during graph building. It was already documented that way, but never enforcedpublicandprotectedfields are now allowed. Fields withprivateand default visibility now produce aUserErrorwhen an access is seen during graph building.This only affects code that uses
JSObjectsubclasses. There, for example compilingJSObjectSubclassTestreduces code size after closure by 15KB from 1536KB to 1521KB