Support cl.exe detection for Simplified-Chinese and other languages

[olpaw]

No description provided.

[peter-hofer]

This is a really annoying issue. Have you considered compiling a temporary C file that prints _MSC_VER or _MSC_FULL_VER, like some build configuration tools do? These macros give you an integer that is relatively easy to deal with: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019

[olpaw]

This is a really annoying issue. Have you considered compiling a temporary C file that prints _MSC_VER or _MSC_FULL_VER, like some build configuration tools do? These macros give you an integer that is relatively easy to deal with: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019

[olpaw]

This is a really annoying issue. Have you considered compiling a temporary C file that prints _MSC_VER or _MSC_FULL_VER, like some build configuration tools do? These macros give you an integer that is relatively easy to deal with: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019

See #2480 (comment)

[Ferhatos]

Hello,
Thank you for this investigation and fixe. I can't compile project, but I've the same problem with French version and GRAAL 20.1.0 :
Compilateur d'optimisation Microsoft (R) C/C++ version 19.00.24245 pour x64

Thanks

[olpaw]

@Ferhatos are you sure you are testing on latest master.
Running the following check

--- a/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/c/codegen/CCompilerInvoker.java
+++ b/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/c/codegen/CCompilerInvoker.java
@@ -73,6 +73,7 @@ public abstract class CCompilerInvoker {
     }
 
     public static CCompilerInvoker create(Path tempDirectory) {
+        testWindowsCCompilerInvoker(tempDirectory);
         OS hostOS = OS.getCurrent();
         switch (hostOS) {
             case LINUX:
@@ -86,6 +87,11 @@ public abstract class CCompilerInvoker {
         }
     }
 
+    public static void testWindowsCCompilerInvoker(Path tempDirectory) {
+        CompilerInfo res = WindowsCCompilerInvoker.createCompilerInfoImpl(null, new Scanner("Compilateur d'optimisation Microsoft (R) C/C++ version 19.00.24245 pour x64"));
+        System.out.println(res);
+    }
+
     private static class WindowsCCompilerInvoker extends CCompilerInvoker {
 
         WindowsCCompilerInvoker(Path tempDirectory) {
@@ -122,7 +128,11 @@ public abstract class CCompilerInvoker {
         }
 
         @Override
-        protected CompilerInfo createCompilerInfo(Path compilerPath, Scanner outerScanner) {
+        protected CompilerInfo createCompilerInfo(Path compilerPath, Scanner scanner) {
+            return createCompilerInfoImpl(compilerPath, scanner);
+        }
+
+        private static CompilerInfo createCompilerInfoImpl(Path compilerPath, Scanner outerScanner) {
             try (Scanner scanner = new Scanner(outerScanner.nextLine())) {
                 String targetArch = null;
                 /* For cl.exe the first line holds all necessary information */

shows me that I can detect Compilateur d'optimisation Microsoft (R) C/C++ version 19.00.24245 pour x64 just fine.

[Ferhatos]

@olpaw ,
My proposal is to be more generic solution (no specific code for specific OS language), and to get informations in any OS language environment.

As I said, I've not tested. It was a proposal after reading code. Sorry for that.

So waiting for a snapshot or release so we can go into production with your fixe. Thanks.