Skip to content

Conversation

@logresearch
Copy link
Contributor

This PR addresses an issue in the onFinalize method where the logging statement could potentially mislead the reader into believing that the execution was successful, even in the presence of an error. The logging sequence has been revised to ensure that the log message accurately reflects the method’s state.

Description

Previously, the onFinalize method logged “Executed successfully: “ before checking for errors. This sequence could result in misleading logs when errors are present, as the success message would still be logged.

Changes Made

  • The check for errors (error != null) and the corresponding AssertionError throw now precede the success logging.
  • The log message “Executed successfully: “ is printed only if no errors are detected, ensuring that the success message aligns with the method’s actual state.

Impact

This change ensures that log messages accurately represent the state of the method, providing clearer and more reliable logging output for error tracking and debugging purposes.

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jul 24, 2024
@fniephaus fniephaus requested review from chumer and entlicher August 2, 2024 08:09
@fniephaus
Copy link
Member

Thanks for your contribution. Could you please sign the OCA so we can start integrating this?

@logresearch
Copy link
Contributor Author

Thanks for your contribution. Could you please sign the OCA so we can start integrating this?

Hi @fniephaus,
I've already signed the OCA last week.

@fniephaus
Copy link
Member

@logresearch thanks! are you sure you used the email address mentioned in #9359 (comment)?

@logresearch
Copy link
Contributor Author

@logresearch thanks! are you sure you used the email address mentioned in #9359 (comment)?

OH,NO. I will do it now.

@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Aug 2, 2024
@entlicher
Copy link
Contributor

Your change is in: 978c81e
Thanks for your contribution.

@entlicher entlicher closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants