Merged
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
force-pushed
the
upgrade-nb29
branch
2 times, most recently
from
c0f3888 to
c8c498f
Compare
Achal1607
previously approved these changes
Apr 1, 2026
Member
Achal1607
left a comment
Achal1607
left a comment
There was a problem hiding this comment.
LGTM. Thanks @sid-srini for the upgrade.
1. Removed patches that are already incorporated in NB29.
2. Renamed patches that have unmerged PRs in the NB repo.
- Uses the NB PR patch; rebased to NB29 where needed.
3. Rebased telemetry and notebooks PRs against NB29.
4. Incorporated changes from netbeans PR 8514 in the notebooks
module for reading configurations.
- Also moved the notebook config keys on the LSP client side to
the server-listened keys section.
- A notebook kernel restart allows the new configs to be used,
without LSP server restarting on config change.
5. Updated THIRD_PARTY_LICENSES.txt
6. vscode integration gradle test script modified to use the mainClass
attribute of the application plugin;
- instead of the old mainClassName,
- which is not supported in gradle 9.x bundled with NB 29.
Achal1607
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.