tlshd: Fix the error in kernel capability probe #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue described in https://github.com/oracle/ktls-utils/issues/137
The kernel capability probing introduced in commit 3dd6a9414da ("tlshd: Add extensible kernel capability detection") fails when probing for the second optional netlink attribute
(HANDSHAKE_A_DONE_REMOTE_AUTH). The genl_ctrl_resolve() call returns -12, causing the feature to be incorrectly reported as "not available" even on supporting kernels.
After sending each probe message, explicitly drain the kernel's response by calling nl_recvmsgs_default().
Reported-by: Geliang Tang geliang@kernel.org