Skip to content
This repository was archived by the owner on Mar 29, 2022. It is now read-only.

Conversation

@kksriram
Copy link

@kksriram kksriram commented Aug 9, 2017

Initial draft of a Vault Provider that implements an envelope encryption scheme.

@tjfontaine tjfontaine changed the base branch from master to for/upstream/master/vault_provider_spec August 9, 2017 03:38
@tjfontaine
Copy link

I've rebased this against the desired target branch of for/upstream/master/<feature>.

Should these commits be squashed now?

Ideally we'd have this PR messaging for the form already desired for K8s

@tjfontaine tjfontaine self-requested a review August 9, 2017 04:09
Copy link

@tjfontaine tjfontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I myself prefer line wraps at 80 for markdown, and a single commit :)

@kksriram kksriram merged commit 6405e6f into oracle:for/upstream/master/vault_provider_spec Aug 9, 2017
@brunoborges
Copy link

brunoborges commented Aug 9, 2017

@tjfontaine you may want to consider using protected branches and/or limit Merge button to only Squash merging

kksriram added a commit that referenced this pull request Oct 5, 2017
* Initial version of Vault KMS Provider

* Renamed image file to be consistent with spec name

* Brought spec inline with EnvelopeTransformer interfaces in PR 49350

* Wrap at 80
wu-qiang pushed a commit to wu-qiang/kubernetes-community that referenced this pull request Jan 8, 2018
wu-qiang pushed a commit to wu-qiang/kubernetes-community that referenced this pull request Jan 8, 2018
…lt_provider_spec

Automatic merge from submit-queue.

Vaultproviderspec (oracle#1)

* Initial version of Vault KMS Provider
* Renamed image file to be consistent with spec name
* Brought spec inline with EnvelopeTransformer interfaces in PR 49350
* Wrap at 80
wu-qiang pushed a commit to wu-qiang/kubernetes-community that referenced this pull request Jan 8, 2018
Create breaking-up-the-monolith.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants