chore: remove consideration of line break characters to reduce whitespace false positives #1205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes a small fix to the whitespace rule due to observed false positives on multiline statements by removing consideration of line break characters.
Description of changes
Multiline statements such as :
were being triggered by the whitespace obfuscation rule. This is because
\sincludes\f,\v,\r, and\n, all of which are line break characters. The regex would then match line breaks after the;, and the subsequent code line. To avoid this, the whitespace now only includes the space character and\t.Checklist
verifiedlabel should appear next to all of your commits on GitHub.