Skip to content

Conversation

@art1f1c3R
Copy link
Member

@art1f1c3R art1f1c3R commented Oct 9, 2025

Summary

This PR includes a small fix to the whitespace rule due to observed false positives on multiline statements by removing consideration of line break characters.

Description of changes

Multiline statements such as :

<some code>;

<some code>

were being triggered by the whitespace obfuscation rule. This is because \s includes \f, \v, \r, and \n, all of which are line break characters. The regex would then match line breaks after the ;, and the subsequent code line. To avoid this, the whitespace now only includes the space character and \t.

Checklist

  • I have reviewed the contribution guide.
  • My PR title and commits follow the Conventional Commits convention.
  • My commits include the "Signed-off-by" line.
  • I have signed my commits following the instructions provided by GitHub. Note that we run GitHub's commit verification tool to check the commit signatures. A green verified label should appear next to all of your commits on GitHub.
  • I have updated the relevant documentation, if applicable.
  • I have tested my changes and verified they work as expected.

…pace fps

Signed-off-by: Carl Flottmann <carl.flottmann@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 9, 2025
Signed-off-by: Carl Flottmann <carl.flottmann@oracle.com>
@art1f1c3R art1f1c3R marked this pull request as ready for review October 9, 2025 01:54
@art1f1c3R art1f1c3R requested a review from behnazh-w as a code owner October 9, 2025 01:54
@art1f1c3R art1f1c3R merged commit d25d51d into main Oct 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants