feat: infer chronologically likeliest setuptools version#1260
Merged
AbhinavPradeep merged 3 commits intomainfrom Dec 18, 2025
Merged
Conversation
e523da9 to
179e7ca
Compare
behnazh-w
reviewed
Dec 9, 2025
179e7ca to
cee7023
Compare
behnazh-w
reviewed
Dec 16, 2025
behnazh-w
reviewed
Dec 16, 2025
…en necessary Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
…well. Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
…alueError when parsing datetime and fixing a type annotation in base_spec.py Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
10a99b6 to
f75abab
Compare
behnazh-w
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the case that we cannot find a
pyproject.toml, a["build-system", "requires"]insidepyproject.toml, or we have the existence ofsetup.py/cfgfiles, we infer the version ofsetuptoolsthat is chronologically the likeliest to have been used based on the package's publish datetime.Description of changes
pypi_registry.pyto provide functionality to retrieve the chronologically likeliest setuptools version for a given package. Made a small refactor to the constructor ofPyPIPackageJsonAsset.pypi_spec.pyto use this.PyPIPackageJsonAssetto match its constructor refactor