-
Notifications
You must be signed in to change notification settings - Fork 30
docs: add tutorials for running macaron #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
|
I wonder if we should use expected reports that we use for integration tests as examples in docs to ensure they are always up-to-date 🤔 |
|
I think it's best to keep the example reports up to date automatically. However, I am thinking how could we tell the Sphinx engine to copy the expected reports to the built directory for the final documentation artifact or whether it would complicate our setup 🤔? |
We could add relevant tests in integration tests where expected output is read from these example reports to make sure they are always up-to-date. But we should be careful to not add too many tests as the integration tests are already long. We could also modify some of the existing tests to read the expected output from these sample reports. I'm happy to merge it as it is and track this in a separate issue and PR. |
Can you please add an issue to keep track of it? |
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Close #198 .