Skip to content

Conversation

@tromai
Copy link
Contributor

@tromai tromai commented May 20, 2023

Close #198 .

Trong Nhan Mai added 4 commits May 19, 2023 12:03
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
@tromai tromai added the documentation Improvements or additions to documentation label May 20, 2023
@tromai tromai added this to the Release v0.1.0 milestone May 20, 2023
@tromai tromai self-assigned this May 20, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 20, 2023
@tromai tromai changed the title 198 add tutorials for running macaron docs: add tutorials for running macaron #232 May 20, 2023
@tromai tromai changed the title docs: add tutorials for running macaron #232 docs: add tutorials for running macaron May 20, 2023
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
@tromai tromai marked this pull request as ready for review May 29, 2023 01:47
@behnazh-w
Copy link
Member

I wonder if we should use expected reports that we use for integration tests as examples in docs to ensure they are always up-to-date 🤔

@tromai
Copy link
Contributor Author

tromai commented May 29, 2023

I think it's best to keep the example reports up to date automatically. However, I am thinking how could we tell the Sphinx engine to copy the expected reports to the built directory for the final documentation artifact or whether it would complicate our setup 🤔?

@behnazh-w
Copy link
Member

I think it's best to keep the example reports up to date automatically. However, I am thinking how could we tell the Sphinx engine to copy the expected reports to the built directory for the final documentation artifact or whether it would complicate our setup thinking?

We could add relevant tests in integration tests where expected output is read from these example reports to make sure they are always up-to-date. But we should be careful to not add too many tests as the integration tests are already long. We could also modify some of the existing tests to read the expected output from these sample reports.

I'm happy to merge it as it is and track this in a separate issue and PR.

@behnazh-w
Copy link
Member

I'm happy to merge it as it is and track this in a separate issue and PR.

Can you please add an issue to keep track of it?

@tromai tromai merged commit bc5c8cc into staging May 29, 2023
@tromai tromai deleted the 198-add-tutorials-for-running-macaron branch May 29, 2023 07:40
@tromai tromai linked an issue May 29, 2023 that may be closed by this pull request
3 tasks
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tutorials for running Macaron

2 participants