chore: remove running the policy engine when --show-prelude is provided #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Member
|
As discussed, the scope for this PR/commit should not be |
tromai
changed the title
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
tromai
force-pushed
the
250-using-the-show-prelude-option-in-the-verify-policy-command-still-require-the-path-to-the-policy-file
branch
from
8ab8172 to
abdc003
Compare
Contributor
Author
|
Thanks @behnazh-w, I have renamed the PR and change the commit message. |
behnazh-w
approved these changes
Jun 2, 2023
tromai
deleted the
250-using-the-show-prelude-option-in-the-verify-policy-command-still-require-the-path-to-the-policy-file
branch
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…ed (#270) Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I fixed issue #250 by assigning both
--fileand--show-preludeflags in theverify-policyaction command to a mutual exclusive group.This will effective only allow the user to use either
--fileor--show-preludeat one time.I also refactored the code to generate the prelude from a database to a different method rather than putting it inside the same method used for running the policy engine against the policy file provided in
--file.