Skip to content

Conversation

@nathanwn
Copy link
Member

@nathanwn nathanwn commented Aug 28, 2023

Summary

Closes #433.

  1. Resolve Sphinx warnings caused by:
  • using the __all__ variable in __init__.py files
  • naming two or more classes with the same name
  • Sphinx issues with numpydoc style Attribute section in class docstring
  1. Add a style guide page to Macaron documentation.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 28, 2023
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
@nathanwn nathanwn self-assigned this Aug 29, 2023
…ed sections in markdown files

Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
@nathanwn nathanwn force-pushed the 433-resolve-sphinx-warnings branch from ccfa1e3 to 5e6492f Compare August 29, 2023 07:30
@nathanwn nathanwn changed the title docs: resolve Sphinx warnings caused by API docs docs: resolve Sphinx warnings caused by API reference and add Macaron style guide Aug 29, 2023
@nathanwn nathanwn marked this pull request as ready for review August 29, 2023 07:40
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
@nathanwn nathanwn merged commit 52cecac into staging Sep 1, 2023
@nathanwn nathanwn deleted the 433-resolve-sphinx-warnings branch October 26, 2023 05:16
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
… style guide (#440)

Closes #433.
Resolve Sphinx warnings caused by:
1. using the `__all__` variable in `__init__.py` files
2. naming two or more classes with the same name
3. using `numpydoc` style `Attribute` section in class docstring
Add a style guide page to Macaron documentation.

---------

Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants