Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 21, 2024

No description provided.

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jan 21, 2024
@jsoref
Copy link
Contributor Author

jsoref commented Jan 21, 2024

image

@behnazh-w behnazh-w changed the base branch from main to staging January 21, 2024 21:24
@behnazh-w
Copy link
Member

@jsoref Thanks a lot for the PR. This is awesome. Can you please approve the Contributor Agreement?

@jsoref
Copy link
Contributor Author

jsoref commented Jan 22, 2024

No. Because the app is 💩.

Screenshot_20240122-073305~2.png

Screenshot_20240122-073503~2.png

It doesn't let me get a keyboard to select macaron (on Android).

This is on top of taking forever and a day to load.

Oddly, it let me type-search my country of residence.

@jsoref
Copy link
Contributor Author

jsoref commented Jan 22, 2024

Or

Screenshot_20240122-073806.png

@jsoref
Copy link
Contributor Author

jsoref commented Jan 22, 2024

I was able to sign it using a desktop browser, but please get someone to fix the flow so that it doesn't require one.

@behnazh-w
Copy link
Member

behnazh-w commented Jan 22, 2024

@jsoref Sorry to hear about your bad experience with the OCA app. I have escalated the issue to the team that is in charge of the app.

@jsoref
Copy link
Contributor Author

jsoref commented Jan 22, 2024

Fwiw, I actually hit a bunch of other errors including things that looked like capacity issues or general outages.

There's no particular indication of what to actually expect going forward. At this time, my thing just says "Under review".

@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jan 23, 2024
@behnazh-w behnazh-w changed the title chore: Spelling chore: fix spelling errors Jan 23, 2024
@behnazh-w behnazh-w requested a review from benmss January 23, 2024 23:16
@behnazh-w
Copy link
Member

@jsoref Looks like your commits are not signed. Can you please sign them and also include the Signed-off-by: line?

@jsoref
Copy link
Contributor Author

jsoref commented Jan 23, 2024

Do you mean GPG signed (they all have signed-off-by -- I meticulously fixed all of them)? That's a bridge too far (the number of hoops and stumbling blocks for this project is absurd). I have an expired signature from 2018 and this is the first project to demand that since it expired.

I have an ssh signing key added in 2022 that I'd be willing to use.

Plus, you merged #613 w/o requiring that.

None of these changes should even require concern about (c) as they're all trivial.

@behnazh-w
Copy link
Member

behnazh-w commented Jan 23, 2024

We have turned on a check on GitHub to verify commit signatures. As long as that check passes, it's good. Note that the check has passed for your other PR:
image

But the commits on this PR are missing the verified green tick for some reason.
image

@jsoref
Copy link
Contributor Author

jsoref commented Jan 24, 2024

I think the check just needs to be rerun.

It also should be improved so that you can easily determine what it's actually complaining about.

@jsoref
Copy link
Contributor Author

jsoref commented Jan 24, 2024

Oh, your docs are wrong. That commit was signed w/ an ssh signature:
image

Sure, I can do that here. But you should fix the docs to clarify what it actually tolerates (either "whatever github tolerates" or "gpg / ssh" if it's specifically picky)

Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
jsoref added 18 commits January 23, 2024 19:40
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
@behnazh-w
Copy link
Member

Sure, I can do that here. But you should fix the docs to clarify what it actually tolerates (either "whatever github tolerates" or "gpg / ssh" if it's specifically picky)

Thanks for the suggestion. I have created an issue for it.

@behnazh-w behnazh-w self-requested a review January 24, 2024 01:11
@behnazh-w
Copy link
Member

@jsoref The commits are now signed and the GitHub check passes, thanks. There is only one comment left by @benmss that needs to be addressed.

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>

Signed-off-by: Josh Soref <jsoref@gmail.com>
@behnazh-w behnazh-w merged commit 298e1d8 into oracle:staging Jan 24, 2024
@spavlusieva
Copy link
Member

hi @jsoref, We apology for the inconvenience you've experienced while signing an OCA, and are working on fixing these issues.

@jsoref jsoref deleted the spelling branch January 24, 2024 13:15
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Josh Soref <jsoref@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants