-
Notifications
You must be signed in to change notification settings - Fork 30
chore: fix spelling errors #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
@jsoref Thanks a lot for the PR. This is awesome. Can you please approve the Contributor Agreement? |
|
I was able to sign it using a desktop browser, but please get someone to fix the flow so that it doesn't require one. |
|
@jsoref Sorry to hear about your bad experience with the OCA app. I have escalated the issue to the team that is in charge of the app. |
|
Fwiw, I actually hit a bunch of other errors including things that looked like capacity issues or general outages. There's no particular indication of what to actually expect going forward. At this time, my thing just says "Under review". |
|
Thank you for signing the OCA. |
|
Do you mean GPG signed (they all have signed-off-by -- I meticulously fixed all of them)? That's a bridge too far (the number of hoops and stumbling blocks for this project is absurd). I have an expired signature from 2018 and this is the first project to demand that since it expired. I have an ssh signing key added in 2022 that I'd be willing to use. Plus, you merged #613 w/o requiring that. None of these changes should even require concern about (c) as they're all trivial. |
|
I think the check just needs to be rerun. It also should be improved so that you can easily determine what it's actually complaining about. |
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Thanks for the suggestion. I have created an issue for it. |
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com> Signed-off-by: Josh Soref <jsoref@gmail.com>
|
hi @jsoref, We apology for the inconvenience you've experienced while signing an OCA, and are working on fixing these issues. |
Signed-off-by: Josh Soref <jsoref@gmail.com>







No description provided.