chore: improve the indentation consistency of souffle Makefile goal #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
force-pushed
the
behnazh/fix-Makefile-indentations
branch
2 times, most recently
from
1bf9118 to
9c930d3
Compare
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
behnazh-w
force-pushed
the
behnazh/fix-Makefile-indentations
branch
from
9c930d3 to
5cf01ca
Compare
tromai
approved these changes
Sep 30, 2024
jenstroeger
approved these changes
Sep 30, 2024
Contributor
jenstroeger
left a comment
jenstroeger
left a comment
There was a problem hiding this comment.
Thank you for formatting @behnazh-w, reads much easier now 😁
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
jenstroeger
approved these changes
Sep 30, 2024
Contributor
jenstroeger
left a comment
jenstroeger
left a comment
There was a problem hiding this comment.
The exit 0 for unsupported host OS is intended, right?
Member
Author
Yes, and I added a comment to clarify. |
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…878) Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following improvements to the
soufflegoal of theMakefile:gnu-sedto handle brew, port, and GNU sed on macOS gracefully #877cc @jenstroeger