test: remove unnecessary integration tests for micronaut-test-junit5 #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Contributor
|
We should remove |
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Member
Author
See commit ff53dfb. |
tromai
approved these changes
Sep 30, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…880) Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the integration test
tests/integration/cases/micronaut-projects_micronaut-teststill includesslf4jandcaffeine, which were originally added for the deprecated-coption that allowed manually adding dependencies. Since this is no longer possible, we can reduce the integration test runtime by removing these two cases. Additionally, I updated themicronaut-projects_micronaut-testtest specification to usepurlinstead of the repository path.