Skip to content

Conversation

@shopewf
Copy link
Member

@shopewf shopewf commented Oct 14, 2025

Description

This PR includes updates to the readme to account for the new artifacts being pushed to PyPi. The getting started section has now been much more simplified, and a new section for local dev work has been added for the case where people dont want to use the PyPi artifacts

Also fixes a lot of small issues with the readme's markdown that was not working as intended.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested starting a server using PyPi artifact
  • Tested starting a server using locally installed package

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 14, 2025
README.md Outdated
git clone https://github.com/oracle/mcp.git
cd mcp
```
Follow these instructions to get started as quickly as possible. Once finished, look [here](#local-development) to set up your local development environment if you wish to [contribute](#contributing) code changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop code


For OCI MCP servers, you'll need to install and authenticate using the OCI CLI.

1. Install the [OCI CLI](https://docs.oracle.com/en-us/iaas/Content/API/SDKDocs/cliinstall.htm)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point the users to https://docs.oracle.com/en-us/iaas/Content/API/SDKDocs/clitoken.htm
I am asking because some of the MCP servers that we currently have (db-tools..) do not use oci session authenticate and will actually not work with token-based authentication. It still relies on API key and user-based authentication

Copy link
Member Author

@shopewf shopewf Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you sent is still documentation for token-based authentication, no?

Or are you saying that the db-tools server requires token-based authentication? The wording here is tripping me up a bit

Also, if there is one server that has specific auth requirements, shouldnt that just go in its specific readme instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That document talks about both. https://docs.oracle.com/en-us/iaas/Content/API/SDKDocs/clitoken.htm#clitoken_topic-Starting_a_Tokenbased_CLI_Session_No_Browser has the information on API key-based signing

The db-tools mcp server will not work if you have authenticated the OCI CLI using session authencation. That is a change that I will be submitting soon

What I was thinking was we point to the doc, so if CLI decides to change the auth mechanism, we won't have to in our README. They (CLI) will keep that doc relevant at all times.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we still at least need that cli install link there as that one is just for installing the oci cli in general.

Maybe we can find somewhere else to include that link youve sent

@shopewf shopewf force-pushed the wshope/update-readme-with-pypi-packages branch 2 times, most recently from 0fb5da2 to 1c765a6 Compare October 15, 2025 16:13
README.md Outdated
```
1. Install `uv` from [here](https://docs.astral.sh/uv/getting-started/installation/)
2. Install python with `uv python install 3.13`
3. Configure [OCI authentication](#authentication)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only for the OCI servers; something like?

Suggested change
3. Configure [OCI authentication](#authentication)
3. (for OCI MCP servers) Configure [OCI authentication](#authentication)

Copy link
Member

@gebhardtr gebhardtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment; other than that LGTM

Signed-off-by: will.shope <will.shope@oracle.com>
@shopewf shopewf force-pushed the wshope/update-readme-with-pypi-packages branch from 1c765a6 to c7e07ab Compare October 17, 2025 20:44
@gebhardtr gebhardtr merged commit c44d4a3 into oracle:main Oct 17, 2025
16 checks passed
@gebhardtr gebhardtr deleted the wshope/update-readme-with-pypi-packages branch October 17, 2025 21:54
mayurkhandave pushed a commit to mayurkhandave/mcp that referenced this pull request Oct 20, 2025
Signed-off-by: will.shope <will.shope@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants