-
Notifications
You must be signed in to change notification settings - Fork 71
[CHORE] Improve consistency of servers (part 2) #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Improve consistency of servers (part 2) #79
Conversation
b9bff90 to
c28d6e5
Compare
|
For the time being, let's remove the version bumps from pyproject.toml, init.py, and uv.lock files. Once the CHANGELOG is merged, you can update the corresponding CHANGELOG section to eventually bump the version when we create a release build. |
|
We need to add default reviewers |
c28d6e5 to
ee9ebe8
Compare
src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py
Outdated
Show resolved
Hide resolved
src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py
Outdated
Show resolved
Hide resolved
src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py
Outdated
Show resolved
Hide resolved
src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py
Outdated
Show resolved
Hide resolved
|
oca/grok4
FWIW, I have only installed the identity MCP server in cline and no other server.
-Irfan.
Confidential- Oracle Internal
From: Will Shope ***@***.***>
Date: Monday, December 8, 2025 at 11:19 AM
To: oracle/mcp ***@***.***>
Cc: Irfan Ahmed ***@***.***>, Comment ***@***.***>
Subject: [External] : Re: [oracle/mcp] [CHORE] Improve consistency of servers (part 2) (PR #79)
@shopewf commented on this pull request.
________________________________
In src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py<https://urldefense.com/v3/__https://github.com/oracle/mcp/pull/79*discussion_r2599833051__;Iw!!ACWV5N9M2RV99hQ!JFpXGVSoU0VE8_JiF86Z-zutv6ufrFrHpNKpKQmA3emH-F4vfajh5Eo7uPRPF7Dj9tE5mPkdQ9dYx3FxF46YPJFehA$>:
+
+ try:
+ client = get_identity_client()
+
+ response: oci.response.Response = None
+ has_next_page = True
+ next_page: str = None
+
+ while has_next_page and (limit is None or len(ads) < limit):
+ kwargs = {
+ "tenancy_id": tenancy_id,
+ "page": next_page,
+ "limit": limit,
+ }
+
+ response = client.list_availability_domains(**kwargs)
This is one that Im unable to reproduce, which model are you using?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/oracle/mcp/pull/79*discussion_r2599833051__;Iw!!ACWV5N9M2RV99hQ!JFpXGVSoU0VE8_JiF86Z-zutv6ufrFrHpNKpKQmA3emH-F4vfajh5Eo7uPRPF7Dj9tE5mPkdQ9dYx3FxF46YPJFehA$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABTQILZGNAV6E4QLF32UNBD4AXFM3AVCNFSM6AAAAACNCLPFIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJTGY4TAMRRGA__;!!ACWV5N9M2RV99hQ!JFpXGVSoU0VE8_JiF86Z-zutv6ufrFrHpNKpKQmA3emH-F4vfajh5Eo7uPRPF7Dj9tE5mPkdQ9dYx3FxF46P7DnNPQ$>.
You are receiving this because you commented.
|
|
Oh yeah, I have done that several times.
Hot reload is the need of the hour.
-Irfan.
Confidential- Oracle Internal
From: Will Shope ***@***.***>
Date: Monday, December 8, 2025 at 11:29 AM
To: oracle/mcp ***@***.***>
Cc: Irfan Ahmed ***@***.***>, Comment ***@***.***>
Subject: [External] : Re: [oracle/mcp] [CHORE] Improve consistency of servers (part 2) (PR #79)
@shopewf commented on this pull request.
________________________________
In src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py<https://urldefense.com/v3/__https://github.com/oracle/mcp/pull/79*discussion_r2599859746__;Iw!!ACWV5N9M2RV99hQ!L0QYmFZqrCokBbZAdTzgvO1KSKl8HUUki2h1sBG9IFY1fR4kf009v0vPthIlwcL-HMyvrQIeQvMMNCsuqxYr8eboRQ$>:
-def get_tenancy_info(tenancy_id: str) -> dict:
- identity = get_identity_client()
- tenancy = identity.get_tenancy(tenancy_id).data
- return {
- "id": tenancy.id,
- "name": tenancy.name,
- "description": tenancy.description,
- "home_region_key": tenancy.home_region_key,
- }
+ response: oci.response.Response = None
+ has_next_page = True
+ next_page: str = None
+
+ while has_next_page and (limit is None or len(compartments) < limit):
+ kwargs = {
+ "tenancy_id": tenancy_id,
I think what happened here is I made the change and forgot to rebuild my server so I was using the old binaries
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/oracle/mcp/pull/79*discussion_r2599859746__;Iw!!ACWV5N9M2RV99hQ!L0QYmFZqrCokBbZAdTzgvO1KSKl8HUUki2h1sBG9IFY1fR4kf009v0vPthIlwcL-HMyvrQIeQvMMNCsuqxYr8eboRQ$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABTQIL2PEMOR2TC2NDSKQ334AXGRDAVCNFSM6AAAAACNCLPFIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJTG4ZDEMBVGU__;!!ACWV5N9M2RV99hQ!L0QYmFZqrCokBbZAdTzgvO1KSKl8HUUki2h1sBG9IFY1fR4kf009v0vPthIlwcL-HMyvrQIeQvMMNCsuqxb58NJdpQ$>.
You are receiving this because you commented.
|
04c2d87 to
165d654
Compare
src/oci-resource-search-mcp-server/oracle/oci_resource_search_mcp_server/server.py
Show resolved
Hide resolved
Signed-off-by: will.shope <will.shope@oracle.com>
165d654 to
3219a6a
Compare
|
saw some strangeness re: empty responses:
But this behavior is present in main as well. Opened #90 The rest look good:
|
Description
This PR improves the consistency of the following servers:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran all of the tools on each of the servers manually, and ensured unit tests still work.
Model:
oca/grok4Checklist: