Skip to content

Conversation

@lake-of-dreams
Copy link
Member

  • Refactoring for moving deps to parent pom
  • Move common config to common module
  • Remove duplicate checkstyle config, moved to build-tools
  • Fixed issue with AQJmsConnectionFactory

@lake-of-dreams lake-of-dreams requested a review from andytael April 2, 2025 10:39
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 2, 2025
@andytael
Copy link
Member

andytael commented Apr 2, 2025

@lake-of-dreams If these changes are merged into main will it break the lively that uses Cloudbank? (https://oracle.github.io/microservices-datadriven/cloudbank/). I don't think so as the livelab uses the tag cbv4-1.3.1?

@andytael
Copy link
Member

andytael commented Apr 2, 2025

@lake-of-dreams I think all the copyrights (add 2025) needs to be updated where changes were made.

@lake-of-dreams
Copy link
Member Author

@lake-of-dreams If these changes are merged into main will it break the lively that uses Cloudbank? (https://oracle.github.io/microservices-datadriven/cloudbank/). I don't think so as the livelab uses the tag cbv4-1.3.1?

The instructions at https://oracle.github.io/microservices-datadriven/cloudbank/ will only work with OBaaS <=1.3.0 and thats what it installs in https://oracle.github.io/microservices-datadriven/cloudbank/provision/index.html. Moreover the wiki guides the user to create services from scratch? These changes only meant for and will work with OBaaS >=1.4.0

@lake-of-dreams
Copy link
Member Author

@lake-of-dreams I think all the copyrights (add 2025) needs to be updated where changes were made.

Done

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

@lake-of-dreams lake-of-dreams merged commit 96d6f95 into main Apr 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloudbank OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants