FIX 2 : handling commands, type switch removal #1064
Conversation
Signed-off-by: soulaimanGhailan <soulaiman8ghailan@gmail.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -1,6 +1,11 @@ | |||
| package org.example.oracle.cqrs.command.commands; | |||
|
|
|||
| import lombok.*; | |||
There was a problem hiding this comment.
Don't use *, use the specific imports.
| @@ -1,6 +1,10 @@ | |||
| package org.example.oracle.cqrs.command.commands; | |||
|
|
|||
| import lombok.*; | |||
There was a problem hiding this comment.
Don't use *, use the specific imports.
| import org.springframework.http.HttpHeaders; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.*; |
There was a problem hiding this comment.
Don't use *, use the specific imports.
| commandsProducer.enqueue(new CreateAccountCommand(UUID.randomUUID().toString(), request.getInitialBalance(), request.getCurrency(), accountId)); | ||
|
|
||
| return ResponseEntity.status(HttpStatus.ACCEPTED).header("Location", "/api/queries/status/" + accountId).build(); | ||
| return ResponseEntity.status(HttpStatus.ACCEPTED).header(HttpHeaders.LOCATION, "/api/queries/status/" + accountId).build(); |
There was a problem hiding this comment.
I don't think this should be hardcoded /api/queries/status/ maybe use something like this, just an example:
URI location = ServletUriComponentsBuilder
.fromCurrentRequest()
.path("/{accountId}")
.buildAndExpand(newCustomer.getCustomerId())
.toUri();
return ResponseEntity.created(location).build();
There was a problem hiding this comment.
Thanks for your note you're right, it shouldn't be hardcoded, the query part of the application is meant to be scaled out as a separate service, so I'm now fetching the query basedUrl from the context as environment variable and building it as mentioned
Signed-off-by: soulaimanGhailan <soulaiman8ghailan@gmail.com>
Signed-off-by: soulaimanGhailan <soulaiman8ghailan@gmail.com>
|
2 participants
No description provided.