Multi Framework Installation Helm Support with Comprehensive document… #1122
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
markxnelson
left a comment
markxnelson
left a comment
There was a problem hiding this comment.
i think the readme needs work. it has too much list content and little prose.
| kind: Deployment | ||
| metadata: | ||
| name: {{ include "obaas-app.fullname" . }} | ||
| namespace: {{ .Values.obaas.namespace }} |
There was a problem hiding this comment.
Don't take out this, value is set in values.yaml file
There was a problem hiding this comment.
AI says its not neccessary
No, the namespace: field should not be in the Deployment metadata. It was never there, and it shouldn't be added. The namespace for the Deployment is controlled by Helm's --namespace flag at install time.
There was a problem hiding this comment.
Not necessary, I agree. however we have this parameter. in the values.yaml:
obaas:
namespace: obaas-dev # Replace with your namespace
Which can be used and overridden by the --namespace flag.
If we're going to stick with the flag only why do we need the namespace parameter in values.yaml?
|
3 participants
…ation