Backups should not be written to disk temporarily

[prydie]

Currently, the mysqldump backup provider writes the backup to the local filesystem and then opens the file and returns that as the io.Reader for the object storage client.

mysql-operator/pkg/backup/executor/mysqldump/provider.go

Lines 88 to 108 in 2a251f7

	f, err := os.Create(tmpFile)
	if err != nil {
	return nil, "", err
	}
	defer f.Close()
	zw := gzip.NewWriter(f)
	defer zw.Close()
	cmd.SetStdout(zw)
	glog.V(4).Infof("running cmd: '%v'", cmd)
	err = cmd.Run()
	if err != nil {
	return nil, "", err
	}
	content, err := os.Open(tmpFile)
	if err != nil {
	return nil, "", err
	}
	return content, filepath.Base(tmpFile), nil

We should upload directly to object storage without writing to disk.

[Simon-Li]

@prydie like to contribute if possible, my thought is to use an io.Pipe mechanism to redirect the output of mysqldump to s3 storage store, does this direction look good to you?

[prydie]

@Simon-Li Awesome! I started a branch using io.Pipe but didn't manage to get it working before getting diverted. It might be a helpful starting point though: badf54e.

[Simon-Li]

@prydie ha~, great, will do!