Added per-request namespace capability (on-premises only). #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modified internal timing to use nanoTime() instead of currentTimeMillis(), which can go backwards in specific instances, and made per-request-iteration timeout values more accurate.
oracle-contributor-agreement
bot
added
the
OCA Verified
gmfeinberg
reviewed
Mar 7, 2023
| * Sets the optional namespace. | ||
| * On-premises only. | ||
| * | ||
| * This overrides any default value set in {@link NoSQLHandleConfig}. |
Contributor
There was a problem hiding this comment.
Can you reference the specific interface in this class?
gmfeinberg
approved these changes
Mar 7, 2023
cezarfx
reviewed
Mar 8, 2023
| other.setStartNanos(this.startNanos); | ||
| other.setRetryStats(this.retryStats); | ||
| other.setReadRateLimiter(this.readRateLimiter); | ||
| other.setWriteRateLimiter(this.writeRateLimiter); |
Member
There was a problem hiding this comment.
Shouldn't the namespace be copied too?
cezarfx
reviewed
Mar 8, 2023
| tres.waitForCompletion(handle, 100000, 1000); | ||
|
|
||
| /* drop namespace - use cascade to remove tables */ | ||
| doSysOp(handle, "drop namespace myns cascade"); |
Member
There was a problem hiding this comment.
Maybe verify that the tables and the namespace is gone, with listTables() and listNamespaces()?
Member
Author
There was a problem hiding this comment.
Not sure that really matters for this test, as the @after logic will delete the namespace and tables as well. I added this just to bring it in line with the internal proxy namespace tests. Note it will throw an error if the drop fails.
cezarfx
reviewed
Mar 8, 2023
Member
cezarfx
left a comment
cezarfx
left a comment
There was a problem hiding this comment.
Just a couple of comments, otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added per-request namespace capability (on-premises only).
Also modified internal timing to use nanoTime() instead of
currentTimeMillis(), which can go backwards in specific instances,
and made per-request-iteration timeout values more accurate.