Skip to content

Moved rate limiter log levels to FINE #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connelly38 merged 1 commit into from
Mar 16, 2023
Merged

Moved rate limiter log levels to FINE #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions driver/src/main/java/oracle/nosql/driver/http/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,7 @@ public boolean updateRateLimiters(String tableName, TableLimits limits) {
if (limits == null ||
(limits.getReadUnits() <= 0 && limits.getWriteUnits() <= 0)) {
rateLimiterMap.remove(tableName);
logInfo(logger, "removing rate limiting from table " + tableName);
logFine(logger, "removing rate limiting from table " + tableName);
return false;
}

Expand Down Expand Up @@ -1067,9 +1067,11 @@ public boolean updateRateLimiters(String tableName, TableLimits limits) {
}

rateLimiterMap.update(tableName, RUs, WUs, durationSeconds);
final String msg = String.format("Updated table '%s' to have " +
"RUs=%.1f and WUs=%.1f per second", tableName, RUs, WUs);
logInfo(logger, msg);
if (isLoggable(logger, Level.FINE)) {
final String msg = String.format("Updated table '%s' to have " +
"RUs=%.1f and WUs=%.1f per second", tableName, RUs, WUs);
logFine(logger, msg);
}

return true;
}
Expand Down Expand Up @@ -1321,17 +1323,17 @@ private void updateTableLimiters(String tableName, String compartmentId) {
.setTimeout(1000);
TableResult res = null;
try {
logInfo(logger, "Starting GetTableRequest for table '" +
logFine(logger, "Starting GetTableRequest for table '" +
tableName + "'");
res = (TableResult) this.execute(gtr);
} catch (Exception e) {
logInfo(logger, "GetTableRequest for table '" +
logFine(logger, "GetTableRequest for table '" +
tableName + "' returned exception: " + e.getMessage());
}

if (res == null) {
/* table doesn't exist? other error? */
logInfo(logger, "GetTableRequest for table '" +
logFine(logger, "GetTableRequest for table '" +
tableName + "' returned null");
AtomicLong then = tableLimitUpdateMap.get(tableName);
if (then != null) {
Expand All @@ -1341,11 +1343,11 @@ private void updateTableLimiters(String tableName, String compartmentId) {
return;
}

logInfo(logger, "GetTableRequest completed for table '" +
logFine(logger, "GetTableRequest completed for table '" +
tableName + "'");
/* update/add rate limiters for table */
if (updateRateLimiters(tableName, res.getTableLimits())) {
logInfo(logger, "background thread added limiters for table '" +
logFine(logger, "background thread added limiters for table '" +
tableName + "'");
}
}
Expand Down