Support authentication via instance principals (#155) #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydie
suggested changes
Apr 10, 2018
pkg/oci/config_validate.go
Outdated
| if c.TenancyID != "" { | ||
| allErrs = append(allErrs, field.Forbidden(fldPath.Child("tenancy"), "cannot be used when useInstancePrincipals is enabled")) | ||
| } | ||
| if c.CompartmentID != "" { |
Contributor
There was a problem hiding this comment.
Doesn't need validating as field depreciated (and the replacement field is actually still required for instance principles though it will be looked up dynamically via metadata if not present).
simonlord
force-pushed
the
instance-principals-support
branch
from
62be484 to
5ee73c8
Compare
prydie
approved these changes
Apr 11, 2018
Contributor
|
@simonlord I got the Service E2E test passing on the cluster you provisioned (ESIPP needs a 3 node cluster AFAIK though). Just needed to open up the node port range to Once you've rebased away the merge conflict happy to merge 👍 |
simonlord
force-pushed
the
instance-principals-support
branch
from
5ee73c8 to
41339e3
Compare
Contributor
Author
|
Rebased, ready for merge |
l-technicore
pushed a commit
to l-technicore/oci-cloud-controller-manager
that referenced
this pull request
Jun 14, 2022
…m csi-fss-internal to internal * commit 'd3b894bcde4597c6af3ff235b974b78fb4b98e62': JIRA: OKE-16576 Support Static Provisioning of FSS using CSI Driver with In-transit Encryption.
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for this to manifests/cloud-provider-example.yaml
Added some tests for the configuration
I've tested it and it seems to work, but i'm not 100% sure of what i'm looking for - could do with a second pair of eyes on the pod logs @prydie tomorrow when you have a moment please?