Allow load balancer functionality to be disabled #199
Conversation
|
The code looks good. Due to the way we're implementing this (testing for nil config rather than an explicit flag) if you want to turn load balancing "on" you're now forced to set "something" in the config. We currently mandate that subnets need to be set in config so it's not a problem but when we remove that requirement then this logic becomes a little bit hard to reason about IMO vs being explicit. For instance I might prefer to not set any LB config and would assume that it would be enabled with defaults rather than being disabled entirely. By merging this we're saying that the way to "enable" load balancing on is by explicitly setting config for values that already have defaults. |
pkg/oci/config.go
Outdated
| return cfg, nil | ||
| } | ||
|
|
||
| // LoadBalancerIsDisabled returns a bool based on whether a LoadBalancer |
There was a problem hiding this comment.
Should be LoadBalancerIsEnabled
harveylowndes
force-pushed
the
disable-load-balancer
branch
from
4bbef71 to
ed67907
Compare
|
My preference would be for an explicit enable/disable flag in the CCM load balancer config rather than relying on the "magic" absent config trick. This would be easier to reason about and less likely to result in user confusion. |
harveylowndes
force-pushed
the
disable-load-balancer
branch
from
616e27b to
b8515b4
Compare
…m task/OKE-18125 to internal * commit 'e1cb4074cbf30e2d895207abba29e4c95db799a0': Added missing break statement Reverted pod start timeout change Changed test to make deployment use a single node to spawn pods Changed test to exec into restarted pod to check data JIRA:task/OKE-18125 added test to check data integrity on pod restart
2 participants
Resolves: #198
When the load balancer configuration is completely omitted, the load balancer functionality is disabled. @jhorwit2 suggested we look at using resource quotas:
apiVersion: v1 kind: ResourceQuota metadata: name: lb-count spec: hard: services.loadbalancers: "0"When applied and a load balancer of type service is applied the service is rejected.
Error from server (Forbidden): error when creating "echo-svc.yaml": services "echoheaders" is forbidden: exceeded quota: lb-count, requested: services.loadbalancers=1, used: services.loadbalancers=0, limited: services.loadbalancers=0Shall we simply leave this alone or include this PR as an additional enhancement?