Flexvolume Improvements #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not able to see what failed in the pipeline. Could I get access? |
Member
|
@jbornemann previously there was a blip with Wercker that I have now fixed. The build is now failing due to gofmt errors. |
jbornemann
force-pushed
the
config_restructure_upstream
branch
2 times, most recently
from
706b499 to
efb54c1
Compare
Contributor
Author
|
Is it still complaining about gofmt? My go build didn't detect any formatting errors. I did squash the commits in case it was trying to lint a a particular commit (Its possible one of the commits had those lint errors). |
jbornemann
force-pushed
the
config_restructure_upstream
branch
from
6db3fec to
dbccc79
Compare
Contributor
Author
|
@prydie I had a different version of go than the one in the CI image, so things were formatted differently by gofmt. All fixed now |
Fix gofmt errors config.go restructure, in support of flex driver using common config struct/validation Additional unit tests for config_test.go Additional unit tests on config_validate.go Have flexvolume driver use common config, and delete flexvolume/block/config.go install.py that generates kubeconfig, rather than requiring it in a secret boilerplate change Fix a few typos, and change worker node message to Info, rather than Error.
jbornemann
force-pushed
the
config_restructure_upstream
branch
from
dbccc79 to
929289a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable things this PR accomplishes:
gofmt errors that were failing the build initially
kubeconfig for flexvolume component is generated from the install pod
flexvolume installer doesn't require particular oci-configuration names/paths, or mount paths. Can be invoked much like other provider components (CCM, provisioner)
flexvolume uses common provider configuration
fields generated by the metadata service provide useful log hints if they can not be retrieved
additional common provider configuration unit test coverage