Skip to content

Conversation

@lovababug
Copy link

Added utility class to read system properties to initialize MAX_RETRIES and EXPONENTIAL_BACKOFF_MAX_DELAY values for UploadManager

…ES and EXPONENTIAL_BACKOFF_MAX_DELAY values for UploadManager
@y-chandra
Copy link
Member

Hello @lovababug,
I don't think it would be appropriate to configure the variables via system properties in the SDK code. What I propose is, to add an optional RetryConfiguration field (that defaults to the default retry configuration) to UploadConfiguration, when creating a new instance of the UploadManager, this property can be passed wrapped within the UploadConfiguration. And in the upload method, the request's retryConfiguration can be set to this predefined property. And If you'd like to configure the variables via the system property, you can have that logic in your client code instead and pass it to the constructor.
Please let me know your thoughts...

@lovababug
Copy link
Author

lovababug commented Jul 27, 2020

Hi @y-chandra ,
It sounds good, all we need is a way to make this RETRY_CONFIGURATION field configurable in this SDK. Once it is provided from SDK then we will talk to oci-hdfs-connector (client being used in OCI) team to use this new UploadConfiguration constructor/builder with RetryConfiguration.

Thanks

@y-chandra
Copy link
Member

This feature has been added in the PR (#245) and it has been merged...

@y-chandra y-chandra closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants