Pass RetryConfiguration to UploadManager #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th3jamin
changed the title
Author
|
I thought about adding an additional parameter to the UploadConfiguration class for RetryConfiguration. This would introduce 2 different places where you can specify a RetryConfiguration, the UploadRequest->PutObjectRequest->RetryConfiguration and that new parameter so I decided to just let the UploadRequest->PutObjectRequest->RetryConfiguration flow through. |
y-chandra
reviewed
Aug 21, 2020
...ectstorage-extensions/src/main/java/com/oracle/bmc/objectstorage/transfer/UploadManager.java
Outdated
Show resolved
Hide resolved
y-chandra
reviewed
Aug 21, 2020
...ectstorage-extensions/src/main/java/com/oracle/bmc/objectstorage/transfer/UploadManager.java
Outdated
Show resolved
Hide resolved
y-chandra
reviewed
Aug 21, 2020
...ectstorage-extensions/src/main/java/com/oracle/bmc/objectstorage/transfer/UploadManager.java
Show resolved
Hide resolved
y-chandra
reviewed
Aug 24, 2020
...nsions/src/test/java/com/oracle/bmc/objectstorage/transfer/MultipartObjectAssemblerTest.java
Show resolved
Hide resolved
This was referenced Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is code allows for the ability to explicitly specify the RetryConfiguration for UploadManager.
This allows the RetryConfiguration that can already be set on an UploadRequest to be passed to the underlying MultipartObjectAssembler instance.