Skip to content

Conversation

@Devansh-Jani
Copy link

Added pool.close() and pool.join() in upload method to fix resource leak

Copy link
Member

@github-anurag github-anurag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your contribution :)
The OCI Python CLI team (which is dependent on the Python SDK) is testing these changes and we will merge the PR once those tests pass.

@bhagwatvyas bhagwatvyas merged commit 224c1f9 into oracle:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants