select all is very slow with a large number of projects

[drusifer]

The select all operation (and clear/invert) is very slow when there are a large number of projects in the list. In my example I have about 2000 projects and select all takes about 15 seconds on Chrome and much longer on IE.

I'm using opengrok-1.0 and I think the issue has to do with the code in searchable-option-list that updates the selected display area once per project (see _addSelectionDisplayItem/_removeSelectionDisplayItem).

[vladak]

The project picker performance was addressed in the fix for #1227 that was integrated before 1.0 shipped; looks like more work is needed.

[tulinkry]

We use a plugin which apparently was not designed to handle such data

[drusifer]

I think the biggest issue has to do with the code in _selectionChange which does a linear search on each option. This is getting called a lot with Select All, Clear, and Invert operations and it's probably not needed.

The other big bottleneck is when it updates the display items that show what's been selected here and here. This works by first creating a new element but then hiding it and updating the count of selected projects when there are too many selected. So it's doing a lot of dom manipulation that never gets displayed.

[tulinkry]

I'll get into this next week and try to improve it possibly. If you have a time for this your help is welcome

[amckenna-pinterest]

The slowness is coming from the init_searchable_option_list() function, it would be great if there was an option to disable this and go back to the old style of selecting projects.

[vladak]

How many projects do you have and how long it takes ? pá 15. 2. 2019 2:17 odesílatel amckenna-pinterest <notifications@github.com> napsal:

…

The slowness is coming from the init_searchable_option_list() function, it would be great if there was an option to disable this and go back to the old style of selecting projects. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1665 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzGDGpkmrFPo-nOorOtOVVmpFJNHLGPks5vNgqjgaJpZM4OWOJR> .

[amckenna-pinterest]

We have over 1k projects and it takes a couple seconds.

[amckenna-pinterest]

2.5 seconds for selectAllProjects(), 3.5 seconds for deslectAllProjects();

[vladak]

That's indeed significant.

…

On Fri, Feb 15, 2019 at 7:56 PM amckenna-pinterest ***@***.***> wrote: 2.5 seconds for selectAllProjects(), 3.5 seconds for deslectAllProjects(); — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1665 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzGDAhnwYZj15YuHLmlSRH5dwE5HdQoks5vNwLogaJpZM4OWOJR> .

[amckenna-pinterest]

Really need an easy way to disable this and go back to the old selector. I have a set of patches but they keep breaking on every release.

[vladak]

What do the patches look like ? Perhaps if they can be parametrized it could be accepted as a workaround. Dne pá 22. 3. 2019 19:09 uživatel amckenna-pinterest < notifications@github.com> napsal:

…

Really need an easy way to disable this and go back to the old selector. I have a set of patches but they keep breaking on every release. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1665 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzGDFIiH_ziMhSPobXTWEoDqbwy4YwEks5vZRxQgaJpZM4OWOJR> .

[danielviorreta]

@vladak any update about this?
Currently we have more than 1000 projects and the select all/invert operation takes more than 10 seconds.
We would like to add more projects to our grok instance but with 5000 projects and 250 groups the operation takes almost 2 minutes.
It looks like the big bottleneck is in here

Thanks,
Daniel