P4 filelog parsing update #3104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit to contributing integrations
idodeclare
suggested changes
Apr 8, 2020
Contributor
idodeclare
left a comment
idodeclare
left a comment
There was a problem hiding this comment.
LGTM
You'll need to "include a notice in each of Your Modifications that identifies You as the Contributor of the Modification" per the project license.
Contributor
Author
|
Ah whoops. Been tweaking the code for a while now, but it's my first time actually doing a pull request. Hopefully all good now. |
idodeclare
approved these changes
Apr 9, 2020
Member
|
I don't see you listed on https://www.oracle.com/technetwork/community/oca-486395.html#c Please initiate the OCA process and/or state that you are okay with terms. |
Contributor
Author
|
I'm fine with it. I emailed the form just yesterday so they probably just havent gotten to it yet. |
Member
|
Sounds good, merging. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding -s option to limit the history to only include integrations that affect the file as there can be hundreds of branches listed where where it's not touched and shouldn't be included in the history.
Because the current regex can find p4 path information in the comment sections, only search for P4 paths at the start of the line.