add username and timeout to toString() #3107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idodeclare
approved these changes
Apr 12, 2020
| */ | ||
| private synchronized LdapContext connect() { | ||
| LOGGER.log(Level.INFO, "Server {0} connecting", this.url); | ||
| LOGGER.log(Level.INFO, "Connecting to LDAP server {0} ", this.toString()); |
Contributor
There was a problem hiding this comment.
Nit: is toString() superfluous here and below (and if not, should these logging computations be short-circuited by convention with e.g. if (LOGGER.isLoggable(Level.INFO)))?
Contributor
|
lgtm, I agree with the nitpick, but this is I guess the same debate of explicit versus implicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds more info to the
toString()method ofLdapServer. This aids debugging when authorization framework is reloaded or when a server is reconnecting.