Conversation
Member
aosingh
commented
Apr 20, 2026
aosingh
commented
- Common fixtures must stay centralized in tests/conftest.py.
- Fixtures like setup_test_user, connect, and async_connect should not be redefined inside individual test modules. If a module defines its own version, it can override shared behavior and break the full suite.
- Shared DB/bootstrap behavior should be reused, not duplicated. That includes test-user setup, connection pools, admin bootstrap, and common environment-driven setup.
- Common ACL handling should also stay in tests/conftest.py. I have moved allow_network_acl there so it is implemented once and reused consistently across tests.
oracle-contributor-agreement
Bot
added
the
OCA Verified
ramapemmaraju
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.