ibacm: Fix a memory leak in an acm_open_dev() error path

bvanassche · bvanassche · commit d04d4660d114 · 2020-01-12T19:40:00.000-08:00
This patch fixes the following Coverity complaint: CID 1490689 (linux-rdma#1 of 1): Resource leak (RESOURCE_LEAK) 15. leaked_storage: Variable dev going out of scope leaks the storage it points to. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/ibacm/src/acm.c b/ibacm/src/acm.c
@@ -2654,6 +2654,8 @@ static void acm_open_dev(struct ibv_device *ibdev)
 		return;
 	}
 
+	free(dev);
+
 err1:
 	ibv_close_device(verbs);
 }

Original file line number	Diff line number	Diff line change
`@@ -2654,6 +2654,8 @@ static void acm_open_dev(struct ibv_device *ibdev)`
`2654`	`2654`	`return;`
`2655`	`2655`	`}`
`2656`	`2656`
	`2657`	`+ free(dev);`
	`2658`	`+`
`2657`	`2659`	`err1:`
`2658`	`2660`	`ibv_close_device(verbs);`
`2659`	`2661`	`}`