-
Notifications
You must be signed in to change notification settings - Fork 16
Make sure applications are active in the cluster #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… active. Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: new file: weblogic-azure-aks/src/main/arm/scripts/py-scripts/checkApplicationStatus.py modified: weblogic-azure-aks/src/main/arm/scripts/setupWLSDomain.sh modified: weblogic-azure-aks/src/main/arm/scripts/utility.sh modified: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-create-wls-cluster.bicep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply my small comments.
| serverConfig() | ||
|
|
||
| if inactiveApp == 0: | ||
| print("Summary: all applications are active!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment:
// TIGHT COUPLING: this exact print text is expected to indicate a successful return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| } | ||
|
|
||
| # | ||
| # Make sure all the applciations are running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/py-scripts/checkApplicationStatus.py modified: weblogic-azure-aks/src/main/arm/scripts/utility.sh
This pr is to make sure all the applications are active, if not, stop the deployment.