Skip to content

Conversation

@galiacheng
Copy link
Contributor

This pr is to make sure all the applications are active, if not, stop the deployment.

… active.

Signed-off-by: galiacheng <haixia.cheng@microsoft.com>

 Changes to be committed:
	new file:   weblogic-azure-aks/src/main/arm/scripts/py-scripts/checkApplicationStatus.py
	modified:   weblogic-azure-aks/src/main/arm/scripts/setupWLSDomain.sh
	modified:   weblogic-azure-aks/src/main/arm/scripts/utility.sh
	modified:   weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-create-wls-cluster.bicep
Copy link
Contributor

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply my small comments.

serverConfig()

if inactiveApp == 0:
print("Summary: all applications are active!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment:

// TIGHT COUPLING: this exact print text is expected to indicate a successful return.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @edburns fixed it in 848ce8b

}

#
# Make sure all the applciations are running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: applications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @edburns fixed in 848ce8b

Signed-off-by: galiacheng <haixia.cheng@microsoft.com>

 Changes to be committed:
	modified:   weblogic-azure-aks/src/main/arm/scripts/py-scripts/checkApplicationStatus.py
	modified:   weblogic-azure-aks/src/main/arm/scripts/utility.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants