Check application status after all configurations are set #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edburns
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
After a successful run of these changes in my fork, I am ready to approve this.
https://github.com/edburns/weblogic-azure/actions/runs/1387847286
… set. Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/setupWLSDomain.sh modified: weblogic-azure-aks/src/main/arm/scripts/utility.sh new file: weblogic-azure-aks/src/main/arm/scripts/validateApplications.sh modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep modified: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-create-wls-cluster.bicep new file: weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-validate-applications.bicep
…e option. Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: weblogic-azure-aks/pom.xml modified: weblogic-azure-aks/src/main/bicep/mainTemplate.bicep
Signed-off-by: galiacheng <haixia.cheng@microsoft.com>
Signed-off-by: galiacheng <haixia.cheng@microsoft.com>
|
Discussed with @edburns in the standup meeting, we agreed to make the restrictive "check application ACTIVE state" optional, and set it Successful run: https://github.com/galiacheng/weblogic-azure/actions/runs/1389069252 |
…ox and link to documentation modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json
edburns
approved these changes
Oct 27, 2021
mriccell
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to fix exception introduced by #43. We should check application status after all the configurations are set successfully.
Test:
https://github.com/galiacheng/weblogic-azure/actions/runs/1379978571