resolve parameters in template files with image knowledge #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
approved these changes
Jun 8, 2020
ddsharpe
reviewed
Jun 9, 2020
imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/CommonOptions.java
Outdated
Show resolved
Hide resolved
| * @param options list of option files to resolve the mustache parameters | ||
| * @throws IOException if a file in the fileNames is invalid | ||
| */ | ||
| public static void writeResolvedFiles(List<String> fileNames, List<Object> options) |
imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/CommonOptions.java
Outdated
Show resolved
Hide resolved
imagetool/src/test/java/com/oracle/weblogic/imagetool/cli/menu/CommonOptionsTest.java
Outdated
Show resolved
Hide resolved
imagetool/src/test/java/com/oracle/weblogic/imagetool/cli/menu/CommonOptionsTest.java
Outdated
Show resolved
Hide resolved
ddsharpe
added a commit
that referenced
this pull request
Jun 9, 2020
ddsharpe
reviewed
Jun 9, 2020
| IMG-0070=Failed to find latest patches for {0}, version {1} | ||
| IMG-0071=WDT Operation is set to UPDATE, but the DOMAIN_HOME environment variable was not defined in the base image, {0}. Did you mean to use "--wdtOperation CREATE" to create a new domain? | ||
| IMG-0072=ORACLE_HOME environment variable is not defined in the base image: {0} | ||
| IMG-0073=Invalid file {0} listed in --resolveFiles |
Member
There was a problem hiding this comment.
--resolveFiles does not match the CLA now
ddsharpe
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the parameters in the list of mustache templates specified with new command line argument --resolveFiles. This command line argument takes a comma separated list of path/file names.
The options used to resolve the parameters are from knowledge that the image tool has, such as from the input on the command line.
The options are contained in a single generic file, but can be broken out into multiple files as the mustache command takes in a list of option files.