Update aks sample script with Azure NFS share for storage #2726

galiacheng · 2022-01-21T05:06:05Z

This pr includes script changes to v3.3 for Azure NFS share in the domain on a PV sample of AKS.

Workflow to test the script: https://github.com/galiacheng/weblogic-kubernetes-operator/runs/4916604379?check_suite_focus=true

A live doc for review: https://zealous-dune-0dac9090f.1.azurestaticapps.net/samples/azure-kubernetes-service/domain-on-pv

Changes to be committed:
modified: kubernetes/samples/scripts/common/utility.sh
new file: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-csi-storageaccount-template.yaml
deleted: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pv-template.yaml
modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pvc-template.yaml
modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml
modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh
modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/validate.sh

Signed-off-by: galiacheng haixia.cheng@microsoft.com

Changes to be committed: modified: kubernetes/samples/scripts/common/utility.sh new file: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-csi-storageaccount-template.yaml deleted: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pv-template.yaml modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pvc-template.yaml modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/validate.sh Signed-off-by: galiacheng <haixia.cheng@microsoft.com>

robertpatrick · 2022-01-21T17:48:17Z

@galiacheng Please assign reviewers for this PR...

galiacheng · 2022-01-24T01:52:31Z

Hello @robertpatrick I cannot select any reviewer, could you assign the pr to @rjeberhard and @mriccell, thank you!

tbarnes-us

I only have minor comments. They don't need to block the pull, but you may want to follow up on them.

tbarnes-us · 2022-01-24T19:04:56Z

kubernetes/samples/scripts/common/utility.sh

+    attempts=$((attempts + 1))
+    sleep 1
+    pvc_state=`kubectl get pvc $1 -o jsonpath='{.status.phase}'`
+  done


just a couple of minor comments:

You can check "SECONDS" checks instead of using "attempt count" math to implement timeouts in shell, since SECONDS contains the time since the script started. ("local end_secs=$(SECONDS + 10)" and "[ $SECONDS -le $end_secs]")

attempts should be declared local

Cool, I love the SECONDS method, it will be more accurate.

tbarnes-us · 2022-01-24T19:11:50Z

...s/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

+  nameAvailable=$(echo "$ret" | grep "nameAvailable" | grep "false")
+  if [ -n "$nameAvailable" ]; then
+    echo $ret
+    fail "Storage account ${aksClusterName} is unavaliable."


Minor: unavaliable --> unavailable

tbarnes-us · 2022-01-24T19:23:35Z

...s/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

+  --name ${azureStorageShareName} \
+  --enabled-protocol NFS \
+  --root-squash NoRootSquash \
+  --quota 100


Minor: If you want to aid with tracing/debugging throughout, maybe consider pattern like:

local cmd="az storage share-rm create ... --quota 100" echo "Running cmd '$cmd'" $cmd

Since az is used so frequently, you could make a helper function that does this:

runCmd () { echo "about to run '$*'" $* } runCmd ls /tmp/*.log ~/*.sh

This is a very useful idea to deal with the commands in a same pattern.

local cmd="..." get the output message, while we want to keep the progress message during the az command is running, I will keep the script as it's.

tbarnes-us · 2022-01-24T19:24:37Z

...s/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

+
+function configureStorageAccountNetwork {
+  # get the resource group name of the AKS managed resources
+  aksMCRGName=$(az aks show --name $aksClusterName --resource-group $azureResourceGroupName -o tsv --query "nodeResourceGroup")


minor: define all local variables as "local"

tbarnes-us · 2022-01-24T19:26:32Z

...s/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

-   attempts=0
-   svcState="running"
-   while [ ! "$svcState" == "completed" ] && [ ! $attempts -eq 30 ]; do
+  attempts=0


minor: local

Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: samples/scripts/common/utility.sh modified: samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: samples/scripts/common/utility.sh

galiacheng · 2022-01-25T03:10:37Z

Test: https://github.com/galiacheng/weblogic-kubernetes-operator/runs/4931372317?check_suite_focus=true

Update aks sample script with Azure NFS share for storage

galiacheng mentioned this pull request Jan 21, 2022

Update aks sample with Azure NFS file share for storage #2727

Merged

galiacheng changed the title ~~Update aks sample script with azure NFS share for storage~~ Update aks sample script with Azure NFS share for storage Jan 21, 2022

robertpatrick requested review from mriccell, rjeberhard, rosemarymarano and tbarnes-us January 24, 2022 18:35

tbarnes-us approved these changes Jan 24, 2022

View reviewed changes

galiacheng force-pushed the release/3.3 branch from 582830c to 6139be2 Compare January 25, 2022 02:39

galiacheng added 2 commits January 25, 2022 10:40

applied excellent comments from @tbarnes-us.

27613f6

Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: samples/scripts/common/utility.sh modified: samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

wait a longer time for the pvc bound.

6fbc52f

Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: samples/scripts/common/utility.sh

galiacheng force-pushed the release/3.3 branch from 6139be2 to 6fbc52f Compare January 25, 2022 02:41

mriccell approved these changes Jan 26, 2022

View reviewed changes

robertpatrick merged commit 13c3959 into oracle:release/3.3 Jan 26, 2022

rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Jun 7, 2023

Merge pull request oracle#2726 from galiacheng/release/3.3

0b7247b

Update aks sample script with Azure NFS share for storage

rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Jun 7, 2023

Merge pull request oracle#2726 from galiacheng/release/3.3

67a4745

Update aks sample script with Azure NFS share for storage

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update aks sample script with Azure NFS share for storage #2726

Update aks sample script with Azure NFS share for storage #2726

Uh oh!

galiacheng commented Jan 21, 2022 •

edited

Loading

Uh oh!

robertpatrick commented Jan 21, 2022

Uh oh!

galiacheng commented Jan 24, 2022

Uh oh!

tbarnes-us left a comment

Uh oh!

tbarnes-us Jan 24, 2022

Uh oh!

galiacheng Jan 25, 2022

Uh oh!

tbarnes-us Jan 24, 2022

Uh oh!

tbarnes-us Jan 24, 2022 •

edited

Loading

Uh oh!

galiacheng Jan 25, 2022

Uh oh!

tbarnes-us Jan 24, 2022

Uh oh!

tbarnes-us Jan 24, 2022

Uh oh!

galiacheng commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update aks sample script with Azure NFS share for storage #2726

Update aks sample script with Azure NFS share for storage #2726

Uh oh!

Conversation

galiacheng commented Jan 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robertpatrick commented Jan 21, 2022

Uh oh!

galiacheng commented Jan 24, 2022

Uh oh!

tbarnes-us left a comment

Choose a reason for hiding this comment

Uh oh!

tbarnes-us Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

galiacheng Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

tbarnes-us Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

tbarnes-us Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galiacheng Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

tbarnes-us Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

tbarnes-us Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

galiacheng commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

galiacheng commented Jan 21, 2022 •

edited

Loading

tbarnes-us Jan 24, 2022 •

edited

Loading