Update aks sample with Azure NFS file share for storage #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galiacheng
changed the title
Contributor
Author
|
Hello @rjeberhard @mriccell @rosemarymarano may I have your attention to this PR? Thank you! |
Contributor
rosemarymarano
left a comment
rosemarymarano
left a comment
There was a problem hiding this comment.
Edits and suggestions. There is a degree of content duplication and I did not want to re-enter the same edits/suggestions more than once. Please apply the same edits to all identical content.
| 6. Select logs. | ||
| 7. Select domain1. | ||
| 8. WebLogic Server logs are listed in the folder. | ||
| - Use Azure Storage bowser, make sure you have permission to access the NFS server, see [Azure Storage firewalls and virtual networks document](https://docs.microsoft.com/en-us/azure/storage/common/storage-network-security?tabs=azure-portal) |
Contributor
There was a problem hiding this comment.
bowser, -> browser. (put a period after browser, then capitalize the next sentence.) -> Make sure you have permission..., then please put a period at the end of that sentence.
Contributor
Author
There was a problem hiding this comment.
| 7. Select domain1. | ||
| 8. WebLogic Server logs are listed in the folder. | ||
| - Use Azure Storage bowser, make sure you have permission to access the NFS server, see [Azure Storage firewalls and virtual networks document](https://docs.microsoft.com/en-us/azure/storage/common/storage-network-security?tabs=azure-portal) | ||
| - Mount the same NFS share in an existing virtual machine from Azure, access files from the mounted path, see [Mount Azure NFS file share to Linux](https://docs.microsoft.com/en-us/azure/storage/files/storage-files-how-to-mount-nfs-shares). |
Contributor
There was a problem hiding this comment.
Azure, _ Azure. (put a period after Azure, then capitalize the next sentence.) -> Access files from the mounted path...
Contributor
Author
There was a problem hiding this comment.
| {{%expand "Click here to view the WebLogic Server logs screenshot." %}} | ||
|  | ||
| {{% /expand %}} | ||
| We will use `kubectl exec` to enter the admin server pod to check file system status: |
Contributor
Author
There was a problem hiding this comment.
| kubectl exec -it domain1-admin-server -- df -h | ||
| ``` | ||
|
|
||
| You should find output like the following, with filesystem `${AKS_PERS_STORAGE_ACCOUNT_NAME}.file.core.windows.net:/${AKS_PERS_STORAGE_ACCOUNT_NAME}/${AKS_PERS_SHARE_NAME}`, size `100G`, and mounted on `/shared`: |
Contributor
There was a problem hiding this comment.
You should find output -> You will find output
Contributor
Author
There was a problem hiding this comment.
| ##### Create an Azure Storage account and NFS share | ||
|
|
||
| Create a storage account using the Azure CLI. Note that the storage account name can contain only lowercase letters and numbers, and must be between 3 and 24 characters in length: | ||
| 1. Create an Azure Storage Account |
Contributor
There was a problem hiding this comment.
Create an Azure Storage Account -> Create an Azure Storage Account. (Please put a period at the end of the sentence.)
Contributor
Author
There was a problem hiding this comment.
| 7. Select domain1. | ||
| 8. WebLogic Server logs are listed in the folder. | ||
| - Use Azure Storage bowser, make sure you have permission to access the NFS server, see [Azure Storage firewalls and virtual networks document](https://docs.microsoft.com/en-us/azure/storage/common/storage-network-security?tabs=azure-portal) | ||
| - Mount the same NFS share in an existing virtual machine from Azure, access files from the mounted path, see [Mount Azure NFS file share to Linux](https://docs.microsoft.com/en-us/azure/storage/files/storage-files-how-to-mount-nfs-shares). |
Contributor
There was a problem hiding this comment.
Please make the same edits here that I suggested previously for these statements.
Contributor
Author
There was a problem hiding this comment.
| ##### Create an Azure Storage account and NFS share | ||
|
|
||
| Create a storage account using the Azure CLI. Note that the storage account name can contain only lowercase letters and numbers, and must be between 3 and 24 characters in length: | ||
| 1. Create an Azure Storage Account |
Contributor
There was a problem hiding this comment.
Please make the same edits here that I suggested previously for these statements.
Contributor
Author
There was a problem hiding this comment.
| -l $AKS_PERS_LOCATION \ | ||
| --sku Standard_LRS | ||
| ``` | ||
| Create a storage account using the Azure CLI. Make sure the following values must be specified: |
Contributor
There was a problem hiding this comment.
Please make the same edits here that I suggested previously for these statements.
Contributor
Author
There was a problem hiding this comment.
| 3. Configure network security | ||
|
|
||
| You will see the following output: | ||
| We have to configure the network security allowing access from AKS cluster to the storage account. |
Contributor
There was a problem hiding this comment.
Please make the same edits here that I suggested previously for these statements.
Contributor
Author
There was a problem hiding this comment.
| secret/wlsazure-secret created | ||
| The secret wlsazure-secret has been successfully created in the default namespace. | ||
| ``` | ||
| Firstly, we have to get the virtual network name and the subnet name of the AKS cluster. |
Contributor
There was a problem hiding this comment.
Please make the same edits here that I suggested previously for these statements.
Contributor
Author
There was a problem hiding this comment.
tbarnes-us
reviewed
Jan 24, 2022
| step. | ||
|
|
||
| {{% notice note %}} This sample creates WebLogic Server Pods with reasonable values for memory, CPU, and JVM heap size (as a percentage of memory). These settings were determined by running a skeleton WebLogic domain with minimal or no deployed services and applications on potentially limited or heavily shared container environments. For advice about tuning CPU and memory requests and limits for broader use cases or in a production environment, see the [Pod memory and CPU resources](https://oracle.github.io/weblogic-kubernetes-operator/faq/resource-settings/) FAQ. To supply different values, edit `~/azure/weblogic-on-aks/domain1.yaml` and set the desired values for `serverPodMemoryRequest`, `serverPodMemoryLimit`, `serverPodCpuRequest`, `serverPodCpuLimit` and `javaOptions` before running `./create-domain.sh -i ~/azure/weblogic-on-aks/domain1.yaml -o ~/azure -e -v`. | ||
| {{% notice note %}} This sample creates WebLogic Server pods with reasonable values for memory, CPU, and JVM heap size (as a percentage of memory). You can supply different values. Edit `~/azure/weblogic-on-aks/domain1.yaml` and set the desired values for `serverPodMemoryRequest`, `serverPodMemoryLimit`, `serverPodCpuRequest`, `serverPodCpuLimit` and `javaOptions` before running `./create-domain.sh -i ~/azure/weblogic-on-aks/domain1.yaml -o ~/azure -e -v`. |
There was a problem hiding this comment.
The new notice seems to revert capacity planning guidance text that we all agreed to earlier. Was this done on purpose?
Contributor
Author
There was a problem hiding this comment.
ah, I copied the content from 3.3 doc , will revert them, and also applied the changes to /3.3/content/samples/azure-kubernetes-service/domain-on-pv.md.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Yes, please apply my edits/comments to both docs. Thank you.
Contributor
Author
There was a problem hiding this comment.
Sure @rosemarymarano please have a look at this commit dfddc4c
mriccell
approved these changes
Jan 26, 2022
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: documentation/3.3/content/samples/azure-kubernetes-service/domain-on-pv.md modified: documentation/3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: documentation/3.3/content/samples/azure-kubernetes-service/domain-on-pv.md modified: documentation/3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: deleted: documentation/3.3/content/samples/azure-kubernetes-service/screenshot-logs.png
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: documentation/3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: documentation/staging/content/samples/azure-kubernetes-service/domain-on-pv.md modified: documentation/staging/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt deleted: documentation/staging/content/samples/azure-kubernetes-service/screenshot-logs.png
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: kubernetes/samples/scripts/common/utility.sh new file: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-csi-storageaccount-template.yaml deleted: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pv-template.yaml modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pvc-template.yaml modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/validate.sh
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: documentation/staging/content/samples/azure-kubernetes-service/domain-on-pv.md
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh modified: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/validate.sh
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: ../documentation/3.3/content/samples/azure-kubernetes-service/domain-on-pv.md modified: ../documentation/3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt modified: ../documentation/staging/content/samples/azure-kubernetes-service/domain-on-pv.md modified: ../documentation/staging/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: samples/scripts/common/utility.sh modified: samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: ../documentation/3.3/content/samples/azure-kubernetes-service/domain-on-pv.md modified: ../documentation/staging/content/samples/azure-kubernetes-service/domain-on-pv.md
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: 3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt modified: staging/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt
…ate-aks-cluster-storage.txt Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: 3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt modified: staging/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt
Signed-off-by: galiacheng <haixia.cheng@microsoft.com>
…. This allows localized content to be served, where available. modified: documentation/3.3/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt Signed-off-by: Ed Burns <edburns@microsoft.com>
edburns
reviewed
Jan 26, 2022
| attempts=0 | ||
| svcState="running" | ||
| while [ ! "$svcState" == "completed" ] && [ ! $attempts -eq 30 ]; do | ||
| local attempts=0 |
Contributor
There was a problem hiding this comment.
Nice to see local here. We should probably use it more often.
modified: documentation/staging/content/samples/azure-kubernetes-service/domain-on-pv.md - Fix capitalization. modified: documentation/staging/content/samples/azure-kubernetes-service/includes/create-aks-cluster-storage.txt - Do not use localized URLs. Signed-off-by: Ed Burns <edburns@microsoft.com>
edburns
approved these changes
Jan 26, 2022
robertpatrick
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2726.
Changes:
Live page for review: https://zealous-dune-0dac9090f.1.azurestaticapps.net/samples/azure-kubernetes-service/domain-on-pv
Note that I have removed the specified operator version from staging document and scripts, as it's not available to use v3.3 for coming API version
weblogic.oracle/v9.