Update scrapping ant error handling - #100
Merged
orangecoding merged 1 commit intoJul 22, 2024
Merged
Conversation
orangecoding
requested changes
Jul 13, 2024
| } catch (exception) { | ||
| /* eslint-disable no-console */ | ||
| if (!EXPECTED_STATUS_CODES.includes(exception.response?.status)) { | ||
| if (!EXPECTED_STATUS_CODES.includes(exception.response?.status) && !EXPECTED_STATUS_CODES.includes(Number(exception.message))) { |
Owner
There was a problem hiding this comment.
If the status message is not a number, this would generate an exception no?
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing the PR. That was my first impression, too; however, it returns
/**
* A value that is not a number.
* In equality comparisons, NaN does not equal any value, including itself. To test whether a value is equivalent to NaN, use the isNaN function.
*/
readonly NaN: number;and the if-else block is evaluated as expected. Since I'm not fully proficient with JS, there might be development standards that defer from the implementation. Let me know if that's the case, and I'd be happy to change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for creating and maintaining this helpful tool
I noticed that
scrapping antsends 423 code with a messageand a request doesn't fall into the catch -> retry block. Hence, I'm opening this PR to update the error handling