Skip to content

Improvements - #193

Merged
orangecoding merged 6 commits into
masterfrom
improvements
Sep 26, 2025
Merged

Improvements#193
orangecoding merged 6 commits into
masterfrom
improvements

Conversation

@orangecoding

Copy link
Copy Markdown
Owner

wip

@gorgobacka

gorgobacka commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

If I understand it correctly, your current comparison in getCurrentVersionFromGithub using toCompactNumber will not work, if one positions contains two digits, e.g. 12.2.13 will be larger then 13.0.0.

@orangecoding

Copy link
Copy Markdown
Owner Author

If I understand it correctly, your current comparison in getCurrentVersionFromGithub using toCompactNumber will not work, if one positions contains two digits, e.g. 12.2.13 will be larger then 13.0.0.

Very good catch. Fixed. Thanks!

Christian Kellner and others added 2 commits September 26, 2025 10:40
@orangecoding
orangecoding merged commit 8324357 into master Sep 26, 2025
2 checks passed
@orangecoding
orangecoding deleted the improvements branch September 26, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants