Fix validation and add ntfy as notification adapter - #75
Merged
Conversation
orangecoding
requested changes
Apr 7, 2023
orangecoding
left a comment
orangecoding
left a comment
Owner
There was a problem hiding this comment.
Thanks so much for your contribution. I did not even know about ntfy... 😱
Could you check the comments I made?
| const message = utf8.encode( | ||
| `Address: ${newListing.address} Size: ${newListing.size.replace(/2m/g, '$m^2$')} Price: ${newListing.price}` | ||
| ); | ||
| return fetch(url, { |
Owner
There was a problem hiding this comment.
while I totally appreciate not to use a lib for a simple http call, in this case, it might make sense to use one.
I'm thinking about using this: https://github.com/cityssm/node-ntfy-publish
If you decide against this, at least please don't use utf8 as an external dependency, coz it's unmaintained (last update 6 years ago and tons of issues)
ghost
requested a review
from orangecoding
April 14, 2023 15:01
orangecoding
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ntfy as notification adapter and there was a bug inside the validation of number input which is fixed. This fix was necessary to enable ntfy priority.