Apply E2E review fixes that missed the #22 merge window - #30
Merged
Conversation
…udget, occurrence counting, marker lib cleanup Addresses the deep-review comment on PR #22. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #22 was merged at 05:50:48Z, four seconds before the review-fix commit ed74577 landed on its branch — so the fixes from the deep-review comment on #22 never reached
main. This PR carries exactly that one commit.Contents (see the review comment for full rationale):
ANDROMEDA_INSTALLER_PREFLIGHT_FAILEDbranch was unreachable:%pre --erroronfailaborts before partitioning, so the partition-probe gate exited first with a misleading harness-timeout message. The failure-detection block now runs before the partition probe, and ESP diagnostics presence is a third independent trigger.andromeda-ci-verify:75runsdaily-driver-verifyunconditionally inside the 12-min unit timeout). Comments now state the 600 s host cap is deliberately below the unit timeout, with the rationale; budget arithmetic refreshed (prep ~6 min per run 30732275955; total 176 < 180).grep -ccounts lines, not occurrences; two markers collapsed onto one line after CR-stripping would satisfy "exactly once". Nowgrep -o | wc -l.serial_grepdeleted; input-redirection stderr leak guarded;require_marker_fixed(fixed-strings) added and used for interpolated scenario markers;andromeda-ci-verify.servicebudget comment names its ordered predecessors; matrix artifact glob narrowed to logs/text (no more qcow2/OVMF uploads).Validation:
bash -nclean on all changed scripts;test-installer-platform-guard.shpass (14 cases); layer-budget count mode pass; functional smoke tests for the counting and normalization changes.🤖 Generated with Claude Code