Drop the duplicated shellcheck step in CI - #38
Merged
Conversation
#36 and a concurrent change each added a shell-lint step to the quality job. They sat at different positions in the file, so git merged both without a conflict and the job now lints the same twenty scripts twice. Keep the earlier one: it runs before the multi-minute cargo steps, which is the point of linting here rather than waiting for the E2E runner. Its claim that ubuntu-latest ships shellcheck is borne out -- the merged job has been green with no install step, so the defensive apt fallback in the copy removed here never fired. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36 and a concurrent change each added a shell-lint step to the
qualityjob. Because they landed at different positions in the file, git merged both cleanly and the job now runs shellcheck over the same twenty scripts twice.Keeps the earlier step — it runs before the multi-minute cargo steps, which is the whole reason for linting in this workflow rather than waiting for the E2E runner. Removes the later duplicate, whose defensive
apt-get install shellcheckfallback never fired: the merged job has been green without it, confirming the runner image ships shellcheck.No change in coverage — same glob, same file set, once instead of twice.