feat: move VS Code behind app server - #196
Merged
Merged
Conversation
added 24 commits
August 1, 2026 13:32
Owner
Author
Review: approved ✅Largest PR in the stack (+2633) and it completes the thin-client migration: desktop (#192), LSP (#195), and now VS Code all speak the same protocol to the same app-server. What I checked
Consuming the shared client from #194 rather than a bespoke implementation is what keeps this reviewable at this size — most of the line count is protocol wiring and tests, not new policy. Validation: CI green; VS Code 12 tests pass locally at the stack tip. |
This was referenced Aug 2, 2026
oratis
added a commit
that referenced
this pull request
Aug 2, 2026
…#214) Reworks #166, which was correct in approach but is now incomplete and carries stale docs. `permissions.additionalDirectories` has been declared in the settings schema and read by /permissions for display, but consumed for enforcement nowhere — /add-dir only printed "recorded ... (effective in M3)". Users could reasonably believe it did something. Why the sandbox is the right boundary: the file tools (Read/Write/Edit/ Glob/Grep) already accept any absolute path, so there is no cwd containment to widen. The only thing that actually restricts writes is the OS sandbox wrapping Bash. Enforcing /add-dir therefore means adding those directories to `filesystem.allowWrite`. The part #166 could not have covered: it predates the app-server, and wired only CLI REPL + headless. Since #192/#195/#196, desktop, VS Code and LSP all run through apps/server, so that wiring would have enforced the setting in the CLI and silently ignored it everywhere else — for a security-relevant setting, partial enforcement is worse than none, because it is indistinguishable from full enforcement at the UI. All 7 sandbox assembly sites across 4 files now route through the helper. - core `withAdditionalWritableDirs(sandbox, dirs, cwd?)`: pure, never mutates input, no-op when the sandbox is disabled (never silently enables it), dedupes, and drops non-absolute entries rather than handing them to profile writers that require absolute paths - /add-dir validates the path is an existing directory, stores it absolute (resolved against cwd), refuses duplicates, and lists the current set with no args - BEHAVIOR_PARITY: only the /add-dir row changes. #166 rewrote the whole table with June-era content that would have regressed /btw, /voice, /tasks and /background back to unshipped. (Prettier reflows the table columns; `git diff -w` shows the 2 real lines.) tsc -b --force, lint (--max-warnings=0), format:check, docs:check clean; 1048 tests pass (9 new helper + 6 new /add-dir); build clean. Co-authored-by: t <t@t> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm format:checkpnpm lint(one pre-existing warning)pnpm typecheckpnpm test(960 passed, 12 skipped)pnpm buildpnpm docs:checkStack
Depends on #195.